Minor fixes to Cypress e2e tests#4069
Merged
tdonohue merged 2 commits intoDSpace:mainfrom Mar 12, 2025
Merged
Conversation
tdonohue
added
1 APPROVAL
tdonohue
commented
Mar 12, 2025
Member
Author
tdonohue
left a comment
tdonohue
left a comment
There was a problem hiding this comment.
Merging this immediately as this doesn't modify any DSpace code, just tests & all tests pass.
Plus, the minor changes to the cypress tsconfig.json finally fix some annoying issues with editing our e2e tests in IDEs. If anyone finds issues later on, I'll gladly fix them up.
4science-it
pushed a commit
to 4Science/dspace-angular
that referenced
this pull request
Feb 10, 2026
[CST-2710] avoid using empty user value as valid user Approved-by: Francesco Molinaro
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This small PR fixes two small issues with Cypress e2e tests:
admin-sidebar.cy.ts, as the prior accessibility issue was fixed in Accessibility of the administration menu (submenus) on the left hand side #2178.tsconfig.jsonfor the Cypress tests to allow IDEs (especially VS Code) to recognize*.cy.tsfiles & provide autocomplete, etc.../node_modulesto the (default) list oftypeRootsthat are defined in our roottsconfig.jsonfile. That small addition allows IDEs to more easily locate the type definitions related to Cypress, allowing for autocomplete, etc.Instructions for Reviewers
*.cy.tsfile in thecypressdirectory. Currently, onmain, if you open one of these files, a lot of the type definitions will be unrecognized & you'll see red lines in the opened files. However, with this PR in place, those red lines go away.NOTE: There are no direct changes to DSpace in this PR. The two small changes only impact e2e tests.